[build-utils] Add Node.js 16.x #7772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyBitz
approved these changes
May 9, 2022
gudmundur
reviewed
May 9, 2022
| @@ -4,6 +4,7 @@ import { NowBuildError } from '../errors'; | |||
| import debug from '../debug'; | |||
|
|
|||
| const allOptions = [ | |||
| { major: 16, range: '16.x', runtime: 'nodejs16.x' }, | |||
There was a problem hiding this comment.
Question: Does this mean that we'll default to NodeJS 16.x when this change is merged and deployed? If so, I wonder if want to gradually roll it out?
There was a problem hiding this comment.
Yes if its a new project and there is no package.json engines.node defined.
Existing projects will not be changed.
Codecov Report
@@ Coverage Diff @@
## main #7772 +/- ##
=======================================
Coverage 50.98% 50.98%
=======================================
Files 149 149
Lines 5762 5762
Branches 1455 1455
=======================================
Hits 2938 2938
Misses 2815 2815
Partials 9 9 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Released within 5 hours of AWS' announcement, nice work! |
matthewp
pushed a commit
to withastro/astro
that referenced
this pull request
May 11, 2022
* Removed ignores * Migration to v3 * More changes * Remove legacy redirects * Fail when there is no ENABLE_VC_BUILD * Fix edge * Updated readme * Changeset * Added static mode * Updated documentation * Updated shim * Made edge work! * Updated changeset * Ensure empty dir * Fixed redirects for dynamic paths * Removed extra declaration * Splited imports * Updated readme * Fixed some urls * Deprecated shim! * [test]: Vercel NFT * Beautify * Edge bundle to node 14.19 Vercel runs 14.19.1 (I've checked it manually) * Re-added shim (#3304) * Added `node:` prefix * Use the same bundling as Deno for Edge * Remove esbuild * Fixed shim * Moved nft * Updated changeset * Added note about Edge * fix typo * Added support for Node 16 (vercel/vercel#7772)
natemoo-re
pushed a commit
to natemoo-re/astro-template-minimal
that referenced
this pull request
Sep 30, 2022
* Removed ignores * Migration to v3 * More changes * Remove legacy redirects * Fail when there is no ENABLE_VC_BUILD * Fix edge * Updated readme * Changeset * Added static mode * Updated documentation * Updated shim * Made edge work! * Updated changeset * Ensure empty dir * Fixed redirects for dynamic paths * Removed extra declaration * Splited imports * Updated readme * Fixed some urls * Deprecated shim! * [test]: Vercel NFT * Beautify * Edge bundle to node 14.19 Vercel runs 14.19.1 (I've checked it manually) * Re-added shim (#3304) * Added `node:` prefix * Use the same bundling as Deno for Edge * Remove esbuild * Fixed shim * Moved nft * Updated changeset * Added note about Edge * fix typo * Added support for Node 16 (vercel/vercel#7772)
mimed95
pushed a commit
to mimed95/mimed95.github.io
that referenced
this pull request
Apr 5, 2024
* Removed ignores * Migration to v3 * More changes * Remove legacy redirects * Fail when there is no ENABLE_VC_BUILD * Fix edge * Updated readme * Changeset * Added static mode * Updated documentation * Updated shim * Made edge work! * Updated changeset * Ensure empty dir * Fixed redirects for dynamic paths * Removed extra declaration * Splited imports * Updated readme * Fixed some urls * Deprecated shim! * [test]: Vercel NFT * Beautify * Edge bundle to node 14.19 Vercel runs 14.19.1 (I've checked it manually) * Re-added shim (#3304) * Added `node:` prefix * Use the same bundling as Deno for Edge * Remove esbuild * Fixed shim * Moved nft * Updated changeset * Added note about Edge * fix typo * Added support for Node 16 (vercel/vercel#7772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Node.js 16