Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Fix _next/data resolving priority for dynamic routes #8278

Merged
merged 12 commits into from Aug 2, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 29, 2022

Related Issues

This ensures we include all dynamic routes as data routes when we are resolving data routes with middleware. Without this we can incorrectly resolve a more generic dynamic route that has a data route before matching a more specific dynamic route that doesn't have a data route (e.g. an automatic static optimized page).

Fixes: slack thread

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@ijjk ijjk marked this pull request as ready for review July 29, 2022 23:53
@ijjk ijjk requested a review from TooTallNate as a code owner July 29, 2022 23:53
@ijjk ijjk requested a review from styfle August 2, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: next semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants