New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] Fix _next/data resolving priority for dynamic routes #8278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
commented
Jul 29, 2022
styfle
reviewed
Aug 2, 2022
styfle
reviewed
Aug 2, 2022
styfle
reviewed
Aug 2, 2022
styfle
reviewed
Aug 2, 2022
styfle
approved these changes
Aug 2, 2022
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
This ensures we include all dynamic routes as data routes when we are resolving data routes with middleware. Without this we can incorrectly resolve a more generic dynamic route that has a data route before matching a more specific dynamic route that doesn't have a data route (e.g. an automatic static optimized page).
Fixes: slack thread
馃搵 Checklist
Tests
yarn test-unit
Code Review