Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] Ensure we resolve _next/data dynamic routes correctly with i18n #8297

Merged
merged 2 commits into from Aug 3, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 3, 2022

Related Issues

Follow-up to #8278 this ensures we correctly map _next/data dynamic routes with i18n enabled. The E2E tests in the Next.js repo caught this although added additional coverage here to catch this faster.

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@ijjk ijjk added semver: patch PR contains bug fixes area: next labels Aug 3, 2022
@ijjk ijjk marked this pull request as ready for review August 3, 2022 03:35
@ijjk ijjk requested a review from TooTallNate as a code owner August 3, 2022 03:35
@ijjk ijjk requested a review from styfle August 3, 2022 03:35
@ijjk ijjk merged commit 21ff4a5 into main Aug 3, 2022
@ijjk ijjk deleted the ijjk/fix-i18n-resolve-case branch August 3, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: next semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants