Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Strip scheme from vc inspect argument #8307

Merged
merged 4 commits into from Aug 3, 2022
Merged

[cli] Strip scheme from vc inspect argument #8307

merged 4 commits into from Aug 3, 2022

Conversation

MatthewStanciu
Copy link
Contributor

@MatthewStanciu MatthewStanciu commented Aug 3, 2022 •
edited by styfle

Right now, vc inspect fails to find a deployment if you include http:// before it. But it works with no scheme and with https://.

Since it appears no scheme is what the API looks for anyway, and to avoid confusion, this PR strips any included scheme from the deploymentIdOrHost argument.

馃搵 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@MatthewStanciu MatthewStanciu changed the title [cli] Strip scheme from vc inspect arg [cli] Strip scheme from vc inspect argument Aug 3, 2022
@MatthewStanciu MatthewStanciu marked this pull request as ready for review August 3, 2022 20:18
styfle
styfle reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a test?

styfle
styfle approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 馃

@styfle styfle added area: cli semver: patch PR contains bug fixes labels Aug 3, 2022
@kodiakhq kodiakhq bot merged commit 3316f38 into main Aug 3, 2022
@kodiakhq kodiakhq bot deleted the fix/vc-inspect-scheme branch August 3, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

Assignees
No one assigned
Labels
area: cli semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MatthewStanciu @styfle