Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Strip scheme from vc inspect argument #8307

Merged
merged 4 commits into from
Aug 3, 2022
Merged

[cli] Strip scheme from vc inspect argument #8307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9650aef
Strip scheme
MatthewStanciu Aug 3, 2022
2a22d3e
Merge branch 'main' into fix/vc-inspect-scheme
MatthewStanciu Aug 3, 2022
6cc5900
Use `URL()` and add test
MatthewStanciu Aug 3, 2022
a44966a
Merge branch 'main' into fix/vc-inspect-scheme
MatthewStanciu Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/cli/src/commands/inspect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { Build } from '../types';
import title from 'title';
import { isErrnoException } from '../util/is-error';
import { isAPIError } from '../util/errors-ts';
import { URL } from 'url';

const help = () => {
console.log(`
Expand Down Expand Up @@ -66,7 +67,7 @@ export default async function main(client: Client) {
const { print, log, error } = client.output;

// extract the first parameter
const [, deploymentIdOrHost] = argv._;
let [, deploymentIdOrHost] = argv._;

if (argv._.length !== 2) {
error(`${getCommandName('inspect <url>')} expects exactly one argument`);
Expand All @@ -90,12 +91,16 @@ export default async function main(client: Client) {
throw err;
}

// resolve the deployment, since we might have been given an alias
const depFetchStart = Date.now();

try {
deploymentIdOrHost = new URL(deploymentIdOrHost).hostname;
} catch {}
client.output.spinner(
`Fetching deployment "${deploymentIdOrHost}" in ${chalk.bold(contextName)}`
);

// resolve the deployment, since we might have been given an alias
try {
deployment = await getDeployment(client, deploymentIdOrHost);
} catch (err: unknown) {
Expand Down
11 changes: 11 additions & 0 deletions packages/cli/test/unit/commands/inspect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,17 @@ describe('inspect', () => {
);
});

it('should strip the scheme of a url', async () => {
const user = useUser();
const deployment = useDeployment({ creator: user });
client.setArgv('inspect', `http://${deployment.url}`);
const exitCode = await inspect(client);
expect(exitCode).toEqual(0);
await expect(client.stderr).toOutput(
`> Fetched deployment ${deployment.url} in ${user.username}`
);
});

it('should print error when deployment not found', async () => {
const user = useUser();
useDeployment({ creator: user });
Expand Down