Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Ensure vary header is set for static app paths #8737

Merged
merged 2 commits into from Oct 18, 2022
Merged

[next] Ensure vary header is set for static app paths #8737

merged 2 commits into from Oct 18, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 18, 2022

Related Issues

x-ref: slack thread
x-ref: vercel/next.js#41479

📋 Checklist

Tests

  • The code changed/added as part of this PR has been covered with tests
  • All tests pass locally with yarn test-unit

Code Review

  • This PR has a concise title and thorough description useful to a reviewer
  • Issue from task tracker has a link to this PR

@ijjk ijjk added semver: patch PR contains bug fixes area: next pr: automerge Automatically merge the PR when checks pass labels Oct 18, 2022
@ijjk ijjk changed the title Ensure vary header is set for static app paths [next] Ensure vary header is set for static app paths Oct 18, 2022
@ijjk ijjk marked this pull request as ready for review October 18, 2022 05:42
cb1kenobi
cb1kenobi approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Regarding the TODO, is that something on the roadmap for 2022?

@kodiakhq kodiakhq bot merged commit 300e6c6 into main Oct 18, 2022
@kodiakhq kodiakhq bot deleted the ijjk/add-rsc-vary-header branch October 18, 2022 14:47
@ijjk ijjk mentioned this pull request Oct 18, 2022
Merged
4 tasks
kodiakhq bot pushed a commit that referenced this pull request Oct 18, 2022
@ijjk
[build-utils] Allow initialHeaders and initialStatus for Prerender (#…
82fd2b8 
…8743)

### Related Issues

This allows `initialHeaders` and `initialStatus` for Prender as has been discussed quite a bit so that the proper headers can be applied when serving the fallback.

x-ref: [slack thread](https://vercel.slack.com/archives/C035J346QQL/p1666130102396799?thread_ts=1666122861.189349&cid=C035J346QQL)
x-ref: follow-up to #8737
x-ref: https://github.com/vercel/vercel/blob/dd94dcab3255839c7c9addbba35026dc88cf0e95/packages/next/src/server-build.ts#L970

### 📋 Checklist

<!--
  Please keep your PR as a Draft until the checklist is complete
-->

#### Tests

- [ ] The code changed/added as part of this PR has been covered with tests
- [ ] All tests pass locally with `yarn test-unit`

#### Code Review

- [ ] This PR has a concise title and thorough description useful to a reviewer
- [ ] Issue from task tracker has a link to this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@TooTallNate TooTallNate Awaiting requested review from TooTallNate TooTallNate is a code owner

@EndangeredMassa EndangeredMassa Awaiting requested review from EndangeredMassa EndangeredMassa is a code owner

@styfle styfle Awaiting requested review from styfle

@Ethan-Arrowood Ethan-Arrowood Awaiting requested review from Ethan-Arrowood Ethan-Arrowood is a code owner

Assignees
No one assigned
Labels
area: next pr: automerge Automatically merge the PR when checks pass semver: patch PR contains bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @cb1kenobi