Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-bridge] Fix multiple Set-Cookie headers in streaming mode #9520

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

TooTallNate
Copy link
Member

Multiple Set-Cookie headers are being concat'd instead of being sent individually when in streaming mode.

Non-streaming:

$ curl -v https://01-remix-basics-eqztqyq3y.vercel-support.app/set-cookie 2>&1 | grep cookie
* h2h3 [:path: /set-cookie]
> GET /set-cookie HTTP/2
< set-cookie: foo=bar
< set-cookie: sessionId=38afes7a8

Streaming:

$ curl -v https://01-remix-basics-9b18alizh.vercel-support.app/set-cookie 2>&1 | grep cookie
* h2h3 [:path: /set-cookie]
> GET /set-cookie HTTP/2
< set-cookie: foo=bar,sessionId=38afes7a8

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be good to add a test 👍

@TooTallNate TooTallNate added the pr: automerge Automatically merge the PR when checks pass label Feb 24, 2023
@kodiakhq kodiakhq bot merged commit 2db9678 into main Feb 24, 2023
@kodiakhq kodiakhq bot deleted the tootallnate/vccli-547-fix-multiple-set-cookie-headers branch February 24, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node pr: automerge Automatically merge the PR when checks pass semver: patch PR contains bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants