[build-utils] Handle error during readConfigFile()
#9542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
added
area: build-utils
semver: patch
styfle
requested review from
TooTallNate,
EndangeredMassa,
cb1kenobi and
Ethan-Arrowood
as code owners
cb1kenobi
approved these changes
Feb 24, 2023
pvdz
approved these changes
Feb 24, 2023
| return yaml.safeLoad(str, { filename: name }) as T; | ||
| } | ||
| } catch (error: unknown) { | ||
| console.log(`Error while parsing config file: "${name}"`); |
There was a problem hiding this comment.
Should it not tell the user why it was trying to do this, and/or why it can't continue the build now?
Do we not want to print the actual error that was thrown as a way for the user to debug/see what's wrong?
There was a problem hiding this comment.
It will continue the build. The idea is that whatever tool uses the config file later will have a hard error such as pnpm install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a confusing error: