[go] Go builder improvements #9576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
February 24, 2023 00:03
added 2 commits
March 1, 2023 08:19
|
A kind request to merge this PR soon, so that I can proceed with my project. The issue, which this PR addresses, has blocked my project's deployment for the past 1½ months. /cc @EndangeredMassa @TooTallNate @styfle @cb1kenobi @Ethan-Arrowood |
|
@vedantmgoyal2009 FYI, you can already use this update in a Vercel deployment by setting environment variable |
EndangeredMassa
approved these changes
Mar 15, 2023
|
This pull request fixes multiple issues related to the Go builder, including problems with version selection, module management, Apple Silicon builds, and Windows compatibility. |
styfle
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a handful of Go builder issues all related to the selected Golang version being used to build the function:
go.modversion ignored forvc buildandvc dev, uses systemPATHversion onlyvc devfails ifgo.moddoes not exist.vercel/cache/golanginstead of a global shared dirvc dev, doesn’t reuse go build code/common settingsgo.modset to 1.19 or 1.20, but 1.18 or older is installedvc buildbuilds wrong arch on Apple Silicon/arm64vc buildon Windows doesn't properly resolve "builds" invercel.jsondue to posix separator issuevc buildon Windows fails withpackage <pkg/name> is not in GOROOTdue to posix separator issueactions/setup-gofrom all test workflowsI added a test that tests the
go tidyissue.