[tests] Run unit tests concurrently in chunks #9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing because unit tests are already really fast (roughly 3 min to build and 4 min to run) so this will actually be slower because it will cause actions to get queued due to all the concurrency. |
|
Let's try this out since it appears to fix our unit tests. |
styfle
requested review from
TooTallNate,
EndangeredMassa,
cb1kenobi and
Ethan-Arrowood
as code owners
|
This seems to fix our issue with unit tests being flaky so we can try it out. TODO: remove |
EndangeredMassa
approved these changes
Mar 7, 2023
styfle
added a commit
that referenced
this pull request
Mar 8, 2023
In a previous PR (#9615) the unit tests were moved to separate jobs in the `test.yml` workflow. So we can now change the `test-unit.yml` workflow to simply be `test-lint.yml` to avoid redundancy. I also checked to see if this would affect code coverage but it turns out codecov was [disabled a long time ago](https://app.codecov.io/gh/vercel/vercel).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can separate each package
test-unitinto a separate job. This will help isolate problems and we can re-run CI for a specific package.