New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fs-detectors] Fix turbo@1.8 all filters are inferred #9680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhammond
force-pushed
the
nathanhammond/smarter-turbo-filters
branch
2 times, most recently
from
March 17, 2023 11:09
86dddbf
to
ba35f4d
Compare
nathanhammond
force-pushed
the
nathanhammond/smarter-turbo-filters
branch
from
March 17, 2023 11:30
ba35f4d
to
1969d04
Compare
nathanhammond
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi,
Ethan-Arrowood,
agadzik and
chloetedder
as code owners
March 17, 2023 11:30
Ethan-Arrowood
previously requested changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good!
packages/fs-detectors/test/fixtures/get-monorepo-default-settings/turbo-new/package.json
Outdated
Show resolved
Hide resolved
nathanhammond
force-pushed
the
nathanhammond/smarter-turbo-filters
branch
from
March 21, 2023 08:02
2b368d4
to
9630c32
Compare
nathanhammond
force-pushed
the
nathanhammond/smarter-turbo-filters
branch
from
March 21, 2023 08:03
9630c32
to
ab5e30b
Compare
styfle
changed the title
As of turbo@1.8 all filters are inferred.
[fs-detectors] Fix turbo@1.8 all filters are inferred
Mar 23, 2023
Ethan-Arrowood
approved these changes
Mar 31, 2023
Ethan-Arrowood
added
the
pr: automerge
Automatically merge the PR when checks pass
label
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: fs-detectors
pr: automerge
Automatically merge the PR when checks pass
semver: patch
PR contains bug fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to specify the active folder for
turbo
to identify the context correctly.