[next] Add support for home and global as edge function regions
#9869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi,
Ethan-Arrowood and
ijjk
as code owners
cramforce
reviewed
Apr 28, 2023
| * Normalizes the regions config that comes from the Next.js edge functions manifest. | ||
| * Ensures that config like `home` and `global` are converted to the corresponding Vercel region config. | ||
| * In the future we'll want to make `home` and `global` part of the Build Output API. | ||
| * - `home` refers to the regions set in vercel.json or on the Vercel dashboard project config. |
There was a problem hiding this comment.
ijjk
reviewed
Apr 28, 2023
EndangeredMassa
previously approved these changes
Apr 28, 2023
| * - `home` refers to the regions set in vercel.json or on the Vercel dashboard project config. | ||
| * - `global` refers to all regions. | ||
| */ | ||
| function normalizeRegions(regions: Regions): string[] { |
There was a problem hiding this comment.
suggestion (soft-blocking): add tests
In this or a follow-up PR: Can we add tests?
There was a problem hiding this comment.
We can look at tests in a follow-up yeah
cb1kenobi
previously requested changes
Apr 28, 2023
cb1kenobi
reviewed
Apr 28, 2023
ijjk
previously approved these changes
Apr 28, 2023
ijjk
force-pushed
the
add/global-and-home-region-config
branch
from
3ca9da9
to
7f7a0dc
Compare
ijjk
force-pushed
the
add/global-and-home-region-config
branch
from
58b3ed8
to
84043d9
Compare
ijjk
force-pushed
the
add/global-and-home-region-config
branch
from
84043d9
to
b0f1df1
Compare
ijjk
force-pushed
the
add/global-and-home-region-config
branch
from
b0f1df1
to
95f1df6
Compare
ijjk
force-pushed
the
add/global-and-home-region-config
branch
from
95f1df6
to
27e2094
Compare
ijjk
previously approved these changes
Apr 28, 2023
TooTallNate
previously approved these changes
Apr 28, 2023
…ome-region-config
…/vercel into add/global-and-home-region-config
ijjk
approved these changes
Apr 29, 2023
styfle
changed the title
home and global as edge function regionshome and global as edge function regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
homeandglobalas supported values forregionswhen coming from Next.js. We'll port these to the build output API at a later time.Related Next.js changes: vercel/next.js#48959