Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the use of Node 11 in CircleCI #1154

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

sergiohgz
Copy link
Member

Type: chore

The following has been addressed in the PR:

  • There is a related issue? No
  • Unit or Functional tests are included in the PR No

Description: Use the alias for Node 11 alias in the correct stage of the workflow

@sergiohgz sergiohgz requested a review from a team December 7, 2018 07:08
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 my bad 😆

@juanpicado juanpicado merged commit e4d0dd2 into 4.x Dec 7, 2018
@delete-merged-branch delete-merged-branch bot deleted the fix-4.x-circleci-node-11 branch December 7, 2018 07:09
priscilawebdev pushed a commit that referenced this pull request Dec 8, 2018
chore: add node 11 to circleci (#1153)

chore: fix the use of Node 11 in CircleCI (#1154)

refactor: added css in js, new design, added types

feat: added Tag component

refactor: added modifiers

refactor: replaced by polished ellipsis

refactor: added types, new design and css in js

refactor: removed ul. it needs refactor

refactor: changed media queries

refactor: changed icon height

refactor: changed Header media queries

refactor: removed margin top

refactor: updated snapshots

refactor: removed unnecessary format author

refactor: added license icon & changed size

refactor: changed media queries

refactor: added icon size

refactor: changed media queries

refactor: updated snap

refactor: replaced Description by Details

refactor: updated tests

refactor: fixed modifiers type

feat: created missed types

fix: fixed types

fix: fixed prop type

fix: fixed undefined prop

refactor: replaced label by name

refactor: updated snap

refactor: moved polished to dev

refactor: changed formatAuthor and pkg author type

fix: removed incorrect meta's type

refactor: removed polished

refactor: added spacing & ellipsis mixin

refactor: added modifier type

refactor: changed datetime format

refactor: updated snapshots

refactor: rreplaced polished by mixins func
priscilawebdev pushed a commit that referenced this pull request Dec 10, 2018
chore: add node 11 to circleci (#1153)

chore: fix the use of Node 11 in CircleCI (#1154)

refactor: added css in js, new design, added types

feat: added Tag component

refactor: added modifiers

refactor: replaced by polished ellipsis

refactor: added types, new design and css in js

refactor: removed ul. it needs refactor

refactor: changed media queries

refactor: changed icon height

refactor: changed Header media queries

refactor: removed margin top

refactor: updated snapshots

refactor: removed unnecessary format author

refactor: added license icon & changed size

refactor: changed media queries

refactor: added icon size

refactor: changed media queries

refactor: updated snap

refactor: replaced Description by Details

refactor: updated tests

refactor: fixed modifiers type

feat: created missed types

fix: fixed types

fix: fixed prop type

fix: fixed undefined prop

refactor: replaced label by name

refactor: updated snap

refactor: moved polished to dev

refactor: changed formatAuthor and pkg author type

fix: removed incorrect meta's type

refactor: removed polished

refactor: added spacing & ellipsis mixin

refactor: added modifier type

refactor: changed datetime format

refactor: updated snapshots

refactor: rreplaced polished by mixins func
juanpicado pushed a commit that referenced this pull request Dec 13, 2018
* chore: fix unit test, forgotten line on merge

chore: add node 11 to circleci (#1153)

chore: fix the use of Node 11 in CircleCI (#1154)

refactor: added css in js, new design, added types

feat: added Tag component

refactor: added modifiers

refactor: replaced by polished ellipsis

refactor: added types, new design and css in js

refactor: removed ul. it needs refactor

refactor: changed media queries

refactor: changed icon height

refactor: changed Header media queries

refactor: removed margin top

refactor: updated snapshots

refactor: removed unnecessary format author

refactor: added license icon & changed size

refactor: changed media queries

refactor: added icon size

refactor: changed media queries

refactor: updated snap

refactor: replaced Description by Details

refactor: updated tests

refactor: fixed modifiers type

feat: created missed types

fix: fixed types

fix: fixed prop type

fix: fixed undefined prop

refactor: replaced label by name

refactor: updated snap

refactor: moved polished to dev

refactor: changed formatAuthor and pkg author type

fix: removed incorrect meta's type

refactor: removed polished

refactor: added spacing & ellipsis mixin

refactor: added modifier type

refactor: changed datetime format

refactor: updated snapshots

refactor: rreplaced polished by mixins func

* refactor: updated styled

* fix: added missed semicolon

* refactor: updated media

* refactor: updated tests

* refactor: organized modifiers

* refactor: removed unused imports

* refactor: design adjusts

* refactor: updated snapshot

* refactor: changed minor things

* refactor: updated snapshots

* refactor: commented tests. fix later
@lock
Copy link

lock bot commented Mar 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants