Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while parsing file with MAPI multi-value fields. #3

Closed
verdammelt opened this issue Jul 12, 2014 · 6 comments · Fixed by #6
Closed

Error while parsing file with MAPI multi-value fields. #3

verdammelt opened this issue Jul 12, 2014 · 6 comments · Fixed by #6
Assignees
@verdammelt
Labels
bug datafile

Comments

@verdammelt
Copy link
Owner

Certain winmail.dat files contain MAPI fields which are 'multi-value' fields. These are inconsistently handled by tnef and case result in a termination of processing with the error message:

!!MULTI_VALUE_FLAG seen (0x1205 0x02)
Assertion failed: (!mvf), function mapi_attr_read, file mapi_attr.c, line 250.
Abort trap: 6
@verdammelt verdammelt self-assigned this Jul 12, 2014
@verdammelt
Copy link
Owner Author

See pull request #6

@verdammelt verdammelt mentioned this issue Jul 12, 2014
Merged
@garethrees garethrees mentioned this issue Jul 22, 2014
Closed
@dtimms
Copy link

dtimms commented Aug 8, 2014

Just a note that attempting: make check is showing a test failure in:

FAIL: multi-value-attribute.test
Testsuite summary for tnef 1.4.11
============================================================================
# TOTAL: 13
# PASS:  12
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See tests/files/test-suite.log

Given this issue relates to improvements for mult-value fields, this might be related to these patches.

https://kojipkgs.fedoraproject.org//work/tasks/11/7260011/build.log
I couldn't see a tests/files/test-suite.log file.

@verdammelt
Copy link
Owner Author

I don't have access to a fedora system and it doesn't happen on my system.

Can you send me the files tests/files/multi-value-attribute.* from after the build.

Thanks.

@ileGITimo
Copy link
Contributor

I've tried this on a Fedora 20 system. Error seems to be in the log for multi-value-attribute:
./datafiles/multi-value-attribute.tnef does not exist. Test Failed!
Seems like the multi-valute-attribute.tnef is missing

@dtimms
Copy link

dtimms commented Aug 10, 2014

Hi, I must have looked in the wrong folder for the file noted in the build log. It is present.
I've archived the build result related to tests and multivalue-... I included files each side of them.
It's a gzip; couldn't see how to attach that, so uploaded to:
http://members.iinet.net.au/~timmsy/tnef/tnef-1.4.11-tests.fedora20_build.tar.bz2

@verdammelt
Copy link
Owner Author

I'm going to open a new issue for this fedora issue and then see about getting a fedora image and attempt to replicate.

@verdammelt verdammelt mentioned this issue Aug 23, 2014
Closed
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 16, 2015
Update tnef to 1.4.12:
a85e7db 
* 1.4.12 [31 August 2014]
** Fixing bug in distribution tarball.
*** verdammelt/tnef#9
** Fixing autoconf warnings
*** verdammelt/tnef#4
*** verdammelt/tnef#10
** Fixing compilation warning on Fedora
*** verdammelt/tnef#8

* 1.4.11 [12 July 2014]
** Fixing bug when parsing files with multiple value MAPI attributes
*** verdammelt/tnef#3
** Fixing compilation warnings
*** verdammelt/tnef#5

* 1.4.10 [4 November 2013]
** Incorporating documentation patch from bentley (github)
** Fixing small problems from new versions of automake/gcc

* 1.4.9 [29 February 2012]
** Incorporating patches from Engelke Eschner <tekai@gmx.li>
*** (from github: verdammelt/tnef#1)
*** Fixing some memory leaks
*** printing out MIME types

* 1.4.8 [18 April 2011]
** Switched to Git
** Applied patch for man page from Jari Aalto [patch #3104753]

* 1.4.7 [31 January 2010]
** Reverting to older UTF decoding method.  The public domain UTF converter
   I replaced my buggy/wrong version with was itself buggy and wrong it seems
   (didn't work on some platforms).
** Updating main copyright date notice.

* 1.4.6 [25 August 2009]
** Including patch from Randy Diffenderfer for a variety of fixes & tweaks.
** Replacing my buggy/wrong UTF converter code with public domain UTF converter code.

* 1.4.5 [28 Sept 2008]
** Fixing bug when reading from stdin [Bug #2126695]

* 1.4.4 [29 May 2008]
** Small updates after long absense
** Adding --ignore-checksum feature.
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Nov 6, 2015
Update tnef to 1.4.12:
ceac302 
* 1.4.12 [31 August 2014]
** Fixing bug in distribution tarball.
*** verdammelt/tnef#9
** Fixing autoconf warnings
*** verdammelt/tnef#4
*** verdammelt/tnef#10
** Fixing compilation warning on Fedora
*** verdammelt/tnef#8

* 1.4.11 [12 July 2014]
** Fixing bug when parsing files with multiple value MAPI attributes
*** verdammelt/tnef#3
** Fixing compilation warnings
*** verdammelt/tnef#5

* 1.4.10 [4 November 2013]
** Incorporating documentation patch from bentley (github)
** Fixing small problems from new versions of automake/gcc

* 1.4.9 [29 February 2012]
** Incorporating patches from Engelke Eschner <tekai@gmx.li>
*** (from github: verdammelt/tnef#1)
*** Fixing some memory leaks
*** printing out MIME types

* 1.4.8 [18 April 2011]
** Switched to Git
** Applied patch for man page from Jari Aalto [patch #3104753]

* 1.4.7 [31 January 2010]
** Reverting to older UTF decoding method.  The public domain UTF converter
   I replaced my buggy/wrong version with was itself buggy and wrong it seems
   (didn't work on some platforms).
** Updating main copyright date notice.

* 1.4.6 [25 August 2009]
** Including patch from Randy Diffenderfer for a variety of fixes & tweaks.
** Replacing my buggy/wrong UTF converter code with public domain UTF converter code.

* 1.4.5 [28 Sept 2008]
** Fixing bug when reading from stdin [Bug #2126695]

* 1.4.4 [29 May 2008]
** Small updates after long absense
** Adding --ignore-checksum feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verdammelt verdammelt

Labels
bug datafile
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling multiple values for all MAPI types. verdammelt/tnef
3 participants
@verdammelt @ileGITimo @dtimms