Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing Ori's comment at #35 #41

Merged
merged 9 commits into from
Sep 28, 2017
Merged

Addressing Ori's comment at #35 #41

merged 9 commits into from
Sep 28, 2017

Conversation

kleinay
Copy link
Collaborator

@kleinay kleinay commented Sep 28, 2017

fixing clustering all unlemmatized predicates together by replacing the head lemma with head surface when head lemma is empty. This bug created a cluster of all predicate which their head lemma was empty.

@gabrielStanovsky
Copy link
Collaborator

Looks good to me.
For documentation, can you please just provide a short description in the PR's description (esp. since the link in the header to #35 doesn't work) ?

Thanks

@kleinay kleinay merged commit e6070f5 into vered1986:props Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants