Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important argument disregarded after implicit propositions added #37

Closed
OriShapira opened this issue Sep 17, 2017 · 1 comment
Closed
Assignees
Labels

Comments

@OriShapira
Copy link
Collaborator

We came across a case where an important implicit proposition was not stated even though PropS has it:

{'Entities': {'A1': ('Hurricane', (0,)),
  'A2': ('Down', (3,)),
  'A3': ('Sandy', (1,)),
  'A4': ('on', (4,)),
  'A5': ('East', (5,))},
 'Predicates': {'P1': {'Arguments': ['A1', 'A2'],
   'Bare predicate': ('Bears', (2,)),
   'Head': {'Lemma': 'Bears', 'POS': 'VBZ', 'Surface': ('Bears', [2])},
   'Template': '{A1} Bears {A2}'},
  'P2': {'Arguments': ('A3', 'A1'),
   'Bare predicate': ('IMPLICIT', (-1,)),
   'Head': {'Lemma': 'IMPLICIT', 'POS': 'IMPLICIT', 'Surface': 'IMPLICIT'},
   'Template': '{A3} {A1}'},
  'P3': {'Arguments': ('A4', 'A2'),
   'Bare predicate': ('IMPLICIT', (-1,)),
   'Head': {'Lemma': 'IMPLICIT', 'POS': 'IMPLICIT', 'Surface': 'IMPLICIT'},
   'Template': '{A4} {A2}'},
  'P4': {'Arguments': ('A5', 'A2'),
   'Bare predicate': ('IMPLICIT', (-1,)),
   'Head': {'Lemma': 'IMPLICIT', 'POS': 'IMPLICIT', 'Surface': 'IMPLICIT'},
   'Template': '{A5} {A2}'}},
 'Sentence': 'Hurricane Sandy Bears Down on East Coast'}

Here "East Coast" is a very important noun phrase that is disregarded and not stated as an implicit proposition.
PropS, however, recognizes it:
Bears:(subj:Hurricane Sandy , prep:Down on East Coast )
(and so does the Berkeley parser).

gabrielStanovsky added a commit that referenced this issue Sep 24, 2017
* Addressing #36 by ordering the implicit arguments according to the order in which they appeared in the sentence

* Addressing #25 by removing implicit entities

* Addressing #37, #38 by better handling of NP modifiers
@gabrielStanovsky
Copy link
Collaborator

I think this was resolved in #39.
Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants