Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api sauce v 14 #67

Merged
merged 10 commits into from Jun 14, 2021
Merged

Remove api sauce v 14 #67

merged 10 commits into from Jun 14, 2021

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Jun 10, 2021

Rebases the latest from v14 into this the removing axios branch.

@aljones15 aljones15 self-assigned this Jun 10, 2021
@aljones15 aljones15 marked this pull request as ready for review June 10, 2021 20:40
@@ -128,17 +137,26 @@ class VeresOneClient {
let result;
try {
result = await httpClient.post(acceleratorUrl, {
json: operation, headers, httpsAgent: this.httpsAgent
json: {operation}, headers, agent: this.httpsAgent
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitrizagidulin this is the only major change in functionality. the post to the accelerator now is {operation} where previously it was just operation. That does need to be reviewed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, k.

Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks!

@dmitrizagidulin dmitrizagidulin merged commit 3a63b44 into v14.x Jun 14, 2021
@dmitrizagidulin dmitrizagidulin deleted the remove-api-sauce-v-14 branch June 14, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants