Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix tor version 3 support for networking #1021

Merged
merged 17 commits into from
Jan 3, 2020

Conversation

marpme
Copy link
Member

@marpme marpme commented Jan 1, 2020

Fix the netaddress conversation between other nodes for tor-v3-nodes.

@marpme marpme changed the title Fix tor version 3 support for networking [WIP] Fix tor version 3 support for networking Jan 1, 2020
@codecov
Copy link

codecov bot commented Jan 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@a8786ad). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1021   +/-   ##
=========================================
  Coverage          ?   43.61%           
=========================================
  Files             ?      360           
  Lines             ?    39822           
  Branches          ?        0           
=========================================
  Hits              ?    17368           
  Misses            ?    22454           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8786ad...71276c7. Read the comment docs.

@@ -15,6 +15,7 @@ static const unsigned char pchGarliCat[] = {0xFD,0x60,0xDB,0x4D,0xDD,0xB5};

// 0xFD + sha256("bitcoin")[0:5]
static const unsigned char g_internal_prefix[] = { 0xFD, 0x6B, 0x88, 0xC0, 0x87, 0x24 };
static const unsigned char pchOnionv3Cat[] = { 0xFD, 0x50, 0xa7, 0xf7, 0xc0, 0xf8};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

append comment how it was built

@@ -10,6 +10,7 @@
#include <config/verge-config.h>
#endif

#include <logging.h>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused remove

@@ -75,7 +75,7 @@ class CNetAddr
bool IsRFC6052() const; // IPv6 well-known prefix (64:FF9B::/96)
bool IsRFC6145() const; // IPv6 IPv4-translated address (::FFFF:0:0:0/96)
bool IsTor() const;
bool IsI2P() const;
bool IsI2P() const;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check indentation

@justinvforvendetta
Copy link
Member

tested, works great. not sure what circles problem is, but we can see that after.

@justinvforvendetta justinvforvendetta merged commit 19ab9ae into master Jan 3, 2020
@2lazy2debug 2lazy2debug deleted the fix-tor-version-supports-networking branch February 22, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants