Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/34 migrate vue2 to vue3 #35

Merged
merged 8 commits into from
Jun 7, 2022

Conversation

cmcWebCode40
Copy link
Contributor

@cmcWebCode40 cmcWebCode40 commented May 24, 2022

Demo

https://www.loom.com/share/9daaa9e2c8ea440eb85ac865a2875217

Resolves #35 #33

@cmcWebCode40 cmcWebCode40 self-assigned this May 24, 2022
@cmcWebCode40 cmcWebCode40 linked an issue May 24, 2022 that may be closed by this pull request
8 tasks
@nick-verida
Copy link
Contributor

Sending a Covid cred doesn't work

image

@cmcWebCode40
Copy link
Contributor Author

@nick-verida, I just tested this now,

I couldn't reproduce this bug, please can you do a short video?

@nick-verida
Copy link
Contributor

@nick-verida, I just tested this now,

I couldn't reproduce this bug, please can you do a short video?

@cmcWebCode40
https://www.loom.com/share/8c864e4a836b4fe5ab6df6cd7e45aea6

@cmcWebCode40
Copy link
Contributor Author

@nick-verida, i have been able to fix the issue I tested using the firefox browser before I could get the same behavior.

you now send covid-19 credential.

Copy link
Contributor

@nick-verida nick-verida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging

@nick-verida nick-verida merged commit c423e6f into develop Jun 7, 2022
@nick-verida nick-verida deleted the feature/34-migrate-vue2-to-vue3 branch June 7, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate to use vue 3 Update Vault Showcase to use the Verida components
2 participants