Fixes #5, Updated EmailValidations#query #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pramodshinde
commented
Oct 26, 2015
pramodshinde
commented
- This was not refreshing response after first initialization in #verify method
- This was not refreshing response after first initialization in #verify method
|
I agree with the implementation, but, you haven't wrote a test to this new behavior. I think we need a test that guarantees that the query method refresh the data from the api until it completes. |
|
@RobertoSchneiders Agree working on it. |
|
👍 |
pramodshinde
force-pushed
the
code-fix
branch
from
bc6605d
to
0c8ea1f
Compare
|
@RobertoSchneiders - Does this looks good? |
pramodshinde
force-pushed
the
code-fix
branch
from
0c8ea1f
to
b797252
Compare
|
|
||
| context "will refresh data - on consecutive calls" do | ||
| let(:incompleted_query) do | ||
| { "progress"=> { "noOfTotalEntries" => 0, "noOfCompletedEntries" => 1 } } |
There was a problem hiding this comment.
should be
{ "progress"=> { "noOfTotalEntries" => 1, "noOfCompletedEntries" => 0 } }
Merged
|
@RobertoSchoneiders - Thank you for such a wonderful feedback I will update and test specs as you suggested. |
|
👍 |
|
👍 Thank you @pramodshinde for your contribution. I will leave this PR open for a while, I hope @verifalia review this too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.