-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #5, Updated EmailValidations#query #10
Conversation
pramodshinde
commented
Oct 26, 2015
- This was not refreshing response after first initialization in #verify method
- This was not refreshing response after first initialization in #verify method
I agree with the implementation, but, you haven't wrote a test to this new behavior. I think we need a test that guarantees that the query method refresh the data from the api until it completes. |
@RobertoSchneiders Agree working on it. |
👍 |
bc6605d
to
0c8ea1f
Compare
@RobertoSchneiders - Does this looks good? |
0c8ea1f
to
b797252
Compare
|
||
context "will refresh data - on consecutive calls" do | ||
let(:incompleted_query) do | ||
{ "progress"=> { "noOfTotalEntries" => 0, "noOfCompletedEntries" => 1 } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
{ "progress"=> { "noOfTotalEntries" => 1, "noOfCompletedEntries" => 0 } }
@RobertoSchoneiders - Thank you for such a wonderful feedback I will update and test specs as you suggested. |
👍 |
👍 Thank you @pramodshinde for your contribution. I will leave this PR open for a while, I hope @verifalia review this too. |