Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize wide vectors to use 64 bit entries #1629

Closed
veripoolbot opened this issue Dec 9, 2019 · 0 comments
Closed

Optimize wide vectors to use 64 bit entries #1629

veripoolbot opened this issue Dec 9, 2019 · 0 comments

Comments

@veripoolbot
Copy link
Contributor

@veripoolbot veripoolbot commented Dec 9, 2019


Author Name: Wilson Snyder (@wsnyder)
Original Redmine Issue: 1629 from https://www.veripool.org

Original Assignee: Wilson Snyder (@wsnyder)


This is to capture notes on a performance experiment.

Verilator uses arrays of 32-bit words for signals over 64 bits. Analyzing some performance reports, it looked like using an array of 64-bit words would greatly shrink the code.

For signals that are e.g. 65-96 bits, going from 332-bits to 264-bits would increase code size and data cache pressure. A quick experiment showed only 3-4% loss.

Then made enough changes to generate some code, got a good 10% improvement though wrong simulation results. Cleaning up further found was missing setting some upper values, and resulted in a 4% loss overall. Therefore abandoning this for now.

Committed to master some changes for this. "EData" is now the entry that a wide vector (WData) is composed of. EData may be redefined as 64 bits. Many defines like VL_EXTEND_I needed changing to have a flavor (generally ..._E) to work when EData is 64 bits. Part of the changes are kept out of master in a branch, as would add dead code that would probably be confusing, and would harm code coverage. The biggest missing piece is code to allow the historical VPI/DPI/user code that needs to see 32-bit arrays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.