Add missing C_internal to is_valid_route_tree. #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
probot-autolabeler
bot
added
lang-cpp
This was referenced Nov 7, 2019
|
Thanks for the fix! This seems to indicate a hole in our regression test coverage. We run vtr_reg_basic and vtr_reg_strong with VTR_ASSERT_LEVEL=3, so it would seem we don't have c_internal tests in those tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe when C_internal support was added, VPR was not tested at
-DVTR_ASSERT_LEVEL=3, and as a result it was not noticed thatis_valid_route_treewas failing.Related Issue
Motivation and Context
Assertion violation on 7-series tests when running at
-DVTR_ASSERT_LEVEL=3.How Has This Been Tested?
Types of changes
Checklist: