Avoid strcpy inside of atom netlist. #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
lang-cpp
vaughnbetz
reviewed
Aug 13, 2020
vpr/src/base/atom_netlist.h
Outdated
| @@ -257,6 +261,10 @@ class AtomNetlist : public Netlist<AtomBlockId, AtomPortId, AtomPinId, AtomNetId | |||
| vtr::vector_map<AtomBlockId, const t_model*> block_models_; //Architecture model of each block | |||
| vtr::vector_map<AtomBlockId, TruthTable> block_truth_tables_; //Truth tables of each block | |||
|
|
|||
| //INPAD and OUTPUT models | |||
There was a problem hiding this comment.
It would be good to comment these new member variables and why they exist:
Something like:
// Input IOs and output IOs always exist and have their own architecture models.
// While their models are already included in block_models_, we also store direct
// pointers to them to make checks of whether a block is an INPAD or OUTPAD fast,
// as such checks are common in some netlist operations (e.g. clean-up of an input netlist).
|
Failure is spurious (just a known memory leak in the graphics test due to the lack of a sanitizer suppression file). |
Signed-off-by: Keith Rothman <537074+litghost@users.noreply.github.com>
litghost
force-pushed
the
avoid_strcpy_in_atom_netlist
branch
from
7a70565
to
45939ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saves around 20 out of 30 seconds in circuit cleaning on baselitex 7-series flow per VPR invocation.
Related Issue
Motivation and Context
We've noticed that the circuit cleaning time was large relative to the overall runtime (30 seconds into 120 second total run). A profile run showed about 20 seconds being spent in a simple string copy to determine if a model is either inpad/outpad.
How Has This Been Tested?
Types of changes
Checklist: