New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom output directory for run_vtr_task and parse_vtr_task scripts #2153
Merged
vaughnbetz
merged 15 commits into
verilog-to-routing:master
from
byuccl:vtr_task_specify_run_dir
Nov 15, 2022
Merged
Add custom output directory for run_vtr_task and parse_vtr_task scripts #2153
vaughnbetz
merged 15 commits into
verilog-to-routing:master
from
byuccl:vtr_task_specify_run_dir
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log-to-routing into vtr_task_specify_run_dir
Looks like a good change and the code looks good. Started CI. |
Everything passed except the python format test. |
Signed-off-by: Jeff Goeders <jeff.goeders@gmail.com>
Signed-off-by: Jeff Goeders <jeff.goeders@gmail.com>
Signed-off-by: Jeff Goeders <jeff.goeders@gmail.com>
@vaughnbetz This should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
-temp_dir <path>
argument to both therun_vtr_task.py
andparse_vtr_task.py
scripts, allowing the user to specify an output directory separate from the standard task directory structure in the VTR source. Without this argument specified, no change is made in the behavior of the tasks scripts.The custom directory acts as the parent "tasks" directory for the output of a set of tasks run and parsed with this argument, and will contain
[task_name]/run[00#]
directories, as well as any generated parse results.Behavior when
-temp_dir
is used in conjunction with other arguments:-create_golden
creates golden results based on the latest task run at the custom path, but still outputs them togolden_results.txt
in the task's config directory, rather than at the custom path.-check_golden
checks the latest run results in the custom directory againstgolden_results.txt
in the task's config directory.-calc_geomean
generates summaries based on the latest task run in the custom directory, and placestask_summary/run[001]_summary.txt
andqor_geomean.txt
in the custom directory.-l
to specify a task list works as expected, organizing the run output of each listed task in the custom directory, so long as the list and the custom directory are both specified in each execution ofrun_vtr_task.py
andparse_vtr_task.py
.Motivation and Context
Users may want to keep their task results separate from the VTR source and the built-in task configurations in their experiments, allowing for easier access and greater flexibility in where experiment data is kept.
How Has This Been Tested?
I ran the
run_vtr_task.py
andparse_vtr_task.py
scripts with each of their existing arguments, then repeated with the-temp_dir
argument to ensure the output was only changed from the current behavior in the ways documented above.For example (from
$VTR_ROOT/vtr_flow/tasks
):../scripts/run_vtr_task.py -temp_dir ~/Desktop/tasks_test/ regression_tests/vtr_reg_basic/basic_timing
../scripts/run_vtr_task.py -temp_dir ~/Desktop/tasks_test/ -check_golden regression_tests/vtr_reg_basic/basic_timing
../scripts/run_vtr_task.py -temp_dir ~/Desktop/tasks_test/ -create_golden regression_tests/vtr_reg_basic/basic_timing
../scripts/run_vtr_task.py -temp_dir ~/Desktop/tasks_test -l regression_tests/vtr_reg_basic/task_list.txt
../scripts/python_libs/vtr/parse_vtr_task.py -temp_dir ~/Desktop/tasks_test -calc_geomean -l regression_tests/vtr_reg_basic/task_list.txt
Types of changes
Checklist: