Fixed a Couple Simple Warnings #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few variables were left unused when CAPNPROTO was disabled which were giving warnings on the CI. Commented these unused variables out.
There were some CMake warnings during compile-time which were complaining about exec_program being deprecated. Replaced with execute_process which is a more verbose command to use anyways.
github-actions
bot
added
VPR
|
@vaughnbetz Please review when you have a moment. |
Instead of having two implementations of the same functions, it is cleaner and would prevent regressions if there was a single implementation with IFDEFs inside of it. Combined the implementations of the ExtendedMapLookaead's read and write methods.
|
@vaughnbetz I have resolved Soheil's comments and it passed CI again. Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the CI build process of the new "R: Basic with CAPNPROTO disabled" job, there were a couple of basic warnings that I thought I would resolve.
The first were some warnings directly caused by CAPNPROTO being disabled:
These were easy to fix by commenting out the unused variables.
Next were some CMake warnings which appear to be affecting all builds:
It looks like the exec_program command was deprecated and the suggested replacement was to use the execute_process command instead. The syntax was similar, but required a few extra arguments in order to properly get the Git version.
Description
Related Issue
Motivation and Context
Some build warnings that showed up that caught my eye and I knew were simple to solve.
How Has This Been Tested?
Types of changes
Checklist: