Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTN-13096 App Configuration - Admin User Role #302

Merged
merged 4 commits into from
Dec 20, 2018
Merged

VTN-13096 App Configuration - Admin User Role #302

merged 4 commits into from
Dec 20, 2018

Conversation

seta-dattran
Copy link
Contributor

atungw
atungw previously requested changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@atungw atungw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test should do more than just see if props.data is being passed. It should check to make sure the DOM element is actually being rendered.

There should be a story that demonstrates this.

@seta-dattran
Copy link
Contributor Author

@olslash We updated following your comment. Could you please take a look at that and review for us. Thanks!

@olslash olslash merged commit 9ba2b11 into master Dec 20, 2018
@olslash olslash deleted the feature/VTN-13096-adddition-menu-item branch December 20, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olslash olslash olslash approved these changes

@atungw atungw atungw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seta-dattran @olslash @atungw