Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Twirpy for Protocol v7 #21

Merged
merged 8 commits into from
Nov 13, 2020
Merged

Update Twirpy for Protocol v7 #21

merged 8 commits into from
Nov 13, 2020

Conversation

avinassh
Copy link
Contributor

@avinassh avinassh commented Nov 13, 2020 •
edited
Loading

  • Updated protoc plugin to generate as per v7
  • Updated docs
  • Updated example which shows use of custom prefix with server_path_prefix param
  • Manually tested
    • with a custom prefix
    • empty prefix
    • default prefix

@avinassh avinassh marked this pull request as ready for review November 13, 2020 09:25
@ofpiyush ofpiyush self-requested a review November 13, 2020 10:14
@ofpiyush
Copy link
Contributor

LGTM.

Now that more people use it outside of verloop, I think we should add tests to be certain any changes are not breaking their use cases.

@avinassh avinassh merged commit bfc6e0a into verloop:master Nov 13, 2020
@avinassh avinassh deleted the protocol-v7 branch November 13, 2020 10:20
@avinassh avinassh mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofpiyush ofpiyush ofpiyush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avinassh @ofpiyush