-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Add color.h test #524
base: master
Are you sure you want to change the base?
Conversation
I added some print statements to
so it fails to find the variable it is trying to redefine in
for So, why is |
Thanks for the investigation. I will look into the ParFORM issue. (You know, in programming, the person you were a month ago is a stranger. Then, the person you were more than 10 years ago is...) By the way, maybe this (the code that gives Valgrind error) should be broken up into small unit tests. |
It seems the problem with valgrind and With Edit: it is some kind of race condition though it seems: if I add a MesPrint in The easiest solution is to just disable valgrind for this test... |
Don't run this test with tform and less than 4 threads, it goes extremely slowly. See discussion in vermaseren#524 .
Once #525 is merged we can rebase this on top and the parform tests will run successfully also. |
This test seems trickier than expected. Currently:
mpirun -np {1,2} parform
: OKmpirun -np {3,4} parform
: hang?mpirun -np {5,6} parform
: crashvalgrind vorm
: OKvalgrind tvorm -w2
: mostlyhangstakes 100-200s, sometimes finishes in 2svalgrind tvorm -w4
: OK, finishes in 2sThe CI sees valgrind errors in
vorm
,tvorm
that I can't reproduce locally. Edit: I can reproduce them on ubuntu 20.04 (as the runners are using) but not in 22.04.