Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for OSX compliation #1407

Closed
wants to merge 1 commit into from
Closed

Conversation

codeadict
Copy link
Contributor

Fixes #1391

This PR adds:

  • Temporarily upgraded to my personal branch of eleveldb, until filled a PR at Modernize to build on OSX and other envs easier eleveldb#5.

  • Fix for OSX compilation due to recent Homebrew changes that added OpenSSL 1.1 and deprecated 1.0, this new way will ensure that compilation always use the latest OpenSSL installed by Homebrew, making it more resilient to changes. Still could be issues on systems that had the previous OpenSSL version and static libraries are still hanging around (The error looks like dyld: Library not loaded: /usr/local/opt/openssl@1.1/lib/libcrypto.1.0.0.dylib), the best on this case is to run:

$ brew update
$ brew uninstall --ignore-dependencies openssl
$ brew install openssl

@ioolkos
Copy link
Contributor

ioolkos commented Jan 5, 2020

@codeadict thanks! :)

@dergraf, @larshesel how and when should we merge this?

@codeadict
Copy link
Contributor Author

I see Travis is failing, I'm gonna test on a Linux machine today to see if I broke something. Can't easily find any clue on Travis logs.

@codeadict
Copy link
Contributor Author

This is passing now, had to install the snappy-dev headers, i'm wondering if this requirement will be an overkill and we can just keep snappy in the repo but with the most recent version. Thoughts @larshesel @dergraf

@dergraf
Copy link
Contributor

dergraf commented Jan 16, 2020

He @codeadict thanks for the contribution. I think we should wait with merging until your PR vernemq/eleveldb#5 is merged and then point to the vernemq/eleveldb repo instead of your fork.

@codeadict
Copy link
Contributor Author

codeadict commented Jan 17, 2020

You are right @dergraf , I'm still working on Adding CI to eleveldb so we know when things break and can have full confidence that it can compile in OSX all the time. The old Travis config is from the Basho days and was not working at all

@codeadict
Copy link
Contributor Author

@dergraf - vernemq/eleveldb#5 is now ready for your feedback

@codeadict
Copy link
Contributor Author

I'll go ahead and point the package to the official vernemq one instead of my fork tonight.

@codeadict
Copy link
Contributor Author

codeadict commented Feb 3, 2020

This is ready now @ioolkos @larshesel , seems like an unrelated test is failing. Can you please take a look.

ioolkos
ioolkos previously approved these changes Feb 6, 2020
@ioolkos
Copy link
Contributor

ioolkos commented Feb 6, 2020

@codeadict great stuff, this seems to need a rebase, then we should be able to merge.

@codeadict
Copy link
Contributor Author

@ioolkos - All rebased now.

@codeadict
Copy link
Contributor Author

Closing in favor of #1423

@codeadict codeadict closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building VerneMQ in macOS Catalina
3 participants