Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1391
This PR adds:
Temporarily upgraded
eleveldb
dependency to compile in OSX.Fix for OSX compilation due to recent Homebrew changes that added OpenSSL 1.1 and deprecated 1.0, this new way will ensure that compilation always use the latest OpenSSL installed by Homebrew, making it more resilient to changes. Still could be issues on systems that had the previous OpenSSL version and static libraries are still hanging around (The error looks like
dyld: Library not loaded: /usr/local/opt/openssl@1.1/lib/libcrypto.1.0.0.dylib
), the best on this case is to run: