Skip to content

Commit

Permalink
Fix. RequestSender.receiveResponse was being rewrited by ByeSender an…
Browse files Browse the repository at this point in the history
…d hence, no authentication was being made for such requests.
  • Loading branch information
jmillan committed Nov 13, 2012
1 parent 3d822ec commit 1ecabf5
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Session.js
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,7 @@ JsSIP.Session = (function() {
this.request = request;
this.send = function() {
var request_sender = new JsSIP.RequestSender(this, session.ua);
this.receiveResponse = function(response){};
request_sender.send();
};
}
Expand All @@ -721,7 +722,7 @@ JsSIP.Session = (function() {
this.request = request;
this.send = function() {
var request_sender = new JsSIP.RequestSender(this, session.ua);
request_sender.receiveResponse = function(response){};
this.receiveResponse = function(response){};
request_sender.send();
};
}
Expand Down

4 comments on commit 1ecabf5

@saghul
Copy link
Contributor

@saghul saghul commented on 1ecabf5 Nov 13, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please begin to use better commit messages?!

@jmillan
Copy link
Member Author

@jmillan jmillan commented on 1ecabf5 Nov 13, 2012 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saghul
Copy link
Contributor

@saghul saghul commented on 1ecabf5 Nov 13, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Fixed authentication for BYE requests"

@jmillan
Copy link
Member Author

@jmillan jmillan commented on 1ecabf5 Nov 13, 2012 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.