Skip to content
Permalink
Browse files

Fix. RequestSender.receiveResponse was being rewrited by ByeSender an…

…d hence, no authentication was being made for such requests.
  • Loading branch information
jmillan committed Nov 13, 2012
1 parent 3d822ec commit 1ecabf5a5cf4cc4e20dbfb62098102e402e5266a
Showing with 2 additions and 1 deletion.
  1. +2 −1 src/Session.js
@@ -700,6 +700,7 @@ JsSIP.Session = (function() {
this.request = request;
this.send = function() {
var request_sender = new JsSIP.RequestSender(this, session.ua);
this.receiveResponse = function(response){};
request_sender.send();
};
}
@@ -721,7 +722,7 @@ JsSIP.Session = (function() {
this.request = request;
this.send = function() {
var request_sender = new JsSIP.RequestSender(this, session.ua);
request_sender.receiveResponse = function(response){};
this.receiveResponse = function(response){};
request_sender.send();
};
}

4 comments on commit 1ecabf5

@saghul

This comment has been minimized.

Copy link
Contributor

saghul replied Nov 13, 2012

Can we please begin to use better commit messages?!

@jmillan

This comment has been minimized.

Copy link
Member Author

jmillan replied Nov 13, 2012

@saghul

This comment has been minimized.

Copy link
Contributor

saghul replied Nov 13, 2012

"Fixed authentication for BYE requests"

@jmillan

This comment has been minimized.

Copy link
Member Author

jmillan replied Nov 13, 2012

Please sign in to comment.
You can’t perform that action at this time.