Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing getter in class RTCSession #481

Closed
michelepra opened this issue Nov 27, 2017 · 0 comments
Closed

missing getter in class RTCSession #481

michelepra opened this issue Nov 27, 2017 · 0 comments

Comments

@michelepra
Copy link

when send refer in RTCSession with replaces option, class ReferSubscriber in method sendRefer need to_tag and from_tag from RTCSession instance, but this attribute is not exposed

maybe missing getter on RTCSession?

get to_tag()
get from_tag()

morrain added a commit to NSFI/JsSIP that referenced this issue Jan 17, 2018
* upsteam: (48 commits)
  3.2.3: Fix versatica#492. Add missing log line for RTCPeerConnection error
  3.2.2: Remove wrong NPM dependencies
  3.2.1: Fix parsing of NOTIFY bodies during a REFER transaction (fixes versatica#493)
  3.2.0
  Config: Fix versatica#491. Implement all documented flavours of 'sockets' parameter.
  Config: new configuration parameter 'user_agent'
  RTCSession/Info: Fix. Call session.sendRequest() with the correct parameters.
  TravisCI: run gulp devel and gulp dist
  Replace deprecated gulp-util with more specific libraries.
  Downgrade pegjs dependency to 0.7.0 (as it must be)
  Update dependencies (fixes a gulp issue with vinly modules)
  .eslintrc: fix sourceType
  3.1.4
  Add .npmignore
  Add .npmignore
  Fix versatica#482 and cleanup Registrator.js
  3.1.3
  Build lib-es5 folder on npm 'prepublishOnly' event
  Produce ES5 tree and expose it as main in package.json (related to versatica#472)
  Fix versatica#481. ReferSubscriber: properly access RTCSession non-public attributes
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant