-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the 'instance_id' UA configuration parameter public #49
Comments
Yeah |
Can we call that "instance_id" ? The implementation uses a URN, but as a concept it expresses an instance identifier: https://tools.ietf.org/html/rfc5626#section-4.1 Also, should jsSIP verify that the given instance id is a valid urn? |
This parameter already exists and its name is Of course, it will verify the urn syntax. |
José Luis Millán wrote:
Great! I hope you don't planto change it to "urn" ;-) |
Not at all. It is The |
Could you please write an example of such a parameter usage? |
It is already implemented internally. I will make the parameter public so it will be validated against the proper syntax as any configuration parameter does. The following can be seen from a running UA instance.
The Contact header in a Register request is generated as it needs to:
|
Please, properly document in the API that the value must not contain "urn:uuid:" nor "<" and ">". Theorically the user provided value should be an entire URN (i.e.: "urn:uuid:xxxx-xxxx-xxxx-xxxx") but we can require just the "xxxx-xxxx-xxxx" fragment if properly documented. |
Yes. First I will take it to the public API, and the document. |
Updates to this issue please? It is marked for 0.3.x but AFAIK it is not. If so better leaving it for 0.4.x. |
No updates at all. Well set to 0.4.x |
New UA configuration parameter: 'instance_id': |
(cherry picked from commit 764dc90) Conflicts: src/Grammar/dist/Grammar.min.js src/Grammar/src/Grammar.pegjs src/UA.js
HI, |
Hi @walidsynclio, The instance_id is a new configuratin parameter in the 'devel' branch. It is not in the current 'master' branch. Are you using the 'devel'? |
Be able to set a custom URN for the
+sip.instance
header param of the REGISTER. Currently a random value like "urn:uuid:9374a213-94d6-40b3-8016-81a87e585e5b" is generated. JsSIP must allow using a provided value.So the param would become:
The text was updated successfully, but these errors were encountered: