New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile #152
Add Makefile #152
Conversation
Hi @dpocock, Is it actually possible to get Grunt itself packaged? Thanks a lot. |
On 13 July 2014 12:04:48 CEST, "José Luis Millán" notifications@github.com wrote:
This has been discussed in #77 and also in Debian ITP bug http://bugs.debian.org/673727 It is difficult for me to estimate how long that will take to be resolved so I provided the Makefile as a workaround so JsSIP can be packaged and distributed. |
Ok, Thanks Daniel. |
Sorry, what has been exactly "merged"? I see nothing. |
The latest version of my Makefile (currently not working) is here: https://github.com/dpocock/JsSIP/blob/pocock-master/Makefile The earlier version does work with earlier JsSIP versions. Now the uglify step fails with some syntax error on the last line of the file. I'm guessing that I have concatenated things in the wrong order. |
That Makefile cannot work with the current "Node style" JsSIP code. We no longer expose all the classes publicly. For example this is wrong:
Yes, IMHO browserify is 100% required, as the build process is not about "files concatenation" anymore. |
Thanks for considering this While Grunt is not available on Debian/Ubuntu, browserify does appear to be: https://packages.qa.debian.org/node-browserify-lite Can we call this from the Makefile somehow? |
Some points:
|
PEGjs runs fine from the Makefile. In Debian, Ubuntu and Fedora there is a commitment to create 100% of a project from the most primitive source artifacts. One reason for this is so that people can add a patch into the package later, it is easier for them to write a patch against the PEGjs input file than patching something that is "compiled". Node is available on Debian too, it is just Grunt that is not available. I'll try that and let you know. |
ok, also note that there is no need for the "Grammar.min" task anymore. |
Here is a Makefile that lets me build JsSIP on Debian without using grunt
I understand you prefer using Grunt, this Makefile shouldn't interfere with Grunt in any way.
Work is in progress to get Grunt itself packaged for Debian and when that is done this Makefile can potentially be removed