WebSocket w/ binary frame

[vf1]

jssip does not understand messages sent in binary frame.

JsSIP | TRANSPORT | Received WebSocket message: 

[object ArrayBuffer]

Binary data received. Ignoring message

Here is possible dirty solution.

  onMessage: function(e) {
    var message, transaction,
      data = (typeof e.data === 'string') ? e.data : String.fromCharCode.apply(null, new Uint8Array(e.data));

[ibc]

Right, for now JsSIP ignores WebSocket binary messages. Does your suggested code convert the received binary data into a real JS string that can be later parsed by JsSIP SIP parser?

BTW when JavaScript receives a WS "binary" message it calls onmessage(data), and such data is:

• Blob (in case WebSocket binaryType attribute is set to "blob", which is the default value).
• ArrayBuffer (in case WebSocket binaryType attribute is set to "arraybuffer").

It seems that using ArrayBuffer is more efficient in case the data will be managed in memory (rather than storing in disk).

Which mode should JsSIP use for binary data? which one will work with your suggested code?

Thanks a lot!

[vf1]

Yes, it is convert. But I did not test it w/ non-ascii symbols.

I did not change anything else. But connect function already has mode selection.

  /**
  * Connect socket.
  */
  connect: function() {
    var transport = this;

    ....

    this.ws.binaryType = 'arraybuffer';

PS. Actually, I am not js developer.

[ibc]

Ok, I will test it by sending a WebSocket binary message to JsSIP after implementing your code, let me sometime to do it. Thanks a lot.

[ibc]

It works, commited. Thanks a lot!