Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix downloaded prebuilt binary check on Windows #1105

Merged
merged 1 commit into from Jun 23, 2023
Merged

Conversation

woodfe
Copy link
Contributor

@woodfe woodfe commented Jun 23, 2023

The download prebuilt binary on Windows always failed because execSync can not found exec file path.

execSync(
	`${WORKER_RELEASE_BIN_PATH}`,

Use path.resolve to convert it to absolute path should be executed by execSync.

const resolvedBinPath = path.resolve(WORKER_RELEASE_BIN_PATH);
execSync(
	resolvedBinPath,

@woodfe woodfe marked this pull request as ready for review June 23, 2023 04:38
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic changes required but I'll make them after merge. Thanks a lot.

@ibc ibc merged commit fe62c16 into versatica:v3 Jun 23, 2023
14 of 18 checks passed
@ibc
Copy link
Member

ibc commented Jun 23, 2023

Please, next time run npm run release:check. It will make all errors show up. For isntance:

/Users/ibc/src/v3-mediasoup/npm-scripts.mjs
  555:6  error  Expected blank line after variable declarations  newline-after-var

✖ 1 problem (1 error, 0 warnings)

I'll do it now, don't worry.

execSync(
`${WORKER_RELEASE_BIN_PATH}`,
resolvedBinPath,

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
@ibc
Copy link
Member

ibc commented Jun 23, 2023

Released in mediasoup 3.12.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants