Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix downloaded prebuilt binary check on Windows #1105

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix downloaded prebuilt binary check on Windows #1105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion npm-scripts.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import { execSync, spawnSync } from 'child_process';
import fetch from 'node-fetch';
import tar from 'tar';
import path from 'path';

const PKG = JSON.parse(fs.readFileSync('./package.json').toString());
const IS_FREEBSD = os.platform() === 'freebsd';
Expand Down Expand Up @@ -551,8 +552,9 @@

try
{
const resolvedBinPath = path.resolve(WORKER_RELEASE_BIN_PATH);

Check failure on line 555 in npm-scripts.mjs

View workflow job for this annotation

GitHub Actions / ci (ubuntu-22.04, 20) 

Expected blank line after variable declarations
execSync(
`${WORKER_RELEASE_BIN_PATH}`,
resolvedBinPath,

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
{
stdio : [ 'ignore', 'ignore', 'ignore' ],
// Ensure no env is passed to avoid accidents.
Expand Down