Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support pre-releases #50

Merged
merged 12 commits into from
Feb 11, 2022
Merged

feat: support pre-releases #50

merged 12 commits into from
Feb 11, 2022

Conversation

saintedlama
Copy link
Collaborator

@saintedlama saintedlama commented Feb 7, 2022 •
edited

A non-non-elegant but working solution

@cabauman
Copy link
Contributor

cabauman commented Feb 8, 2022

Nice. I didn't realize you were going to tackle this feature so soon.

@saintedlama
Copy link
Collaborator Author

Nice. I didn't realize you were going to tackle this feature so soon.

I got motivated by having a co-contributor in the project 🥇

@saintedlama saintedlama marked this pull request as ready for review February 8, 2022 10:05
@coveralls
Copy link

coveralls commented Feb 8, 2022 •
edited

Pull Request Test Coverage Report for Build 1828196599

  • 82 of 116 (70.69%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.3%) to 87.896%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Versionize/Program.cs 3 6 50.0%
Versionize/VersionIncrementStrategy.cs 33 36 91.67%
Versionize/Versioning/PrereleaseIdentifier.cs 23 26 88.46%
Versionize/WorkingCopy.cs 11 16 68.75%
Versionize/Versioning/SemanticVersionExtensions.cs 10 18 55.56%
Versionize/Versioning/InvalidPrereleaseIdentifierException.cs 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
Versionize/WorkingCopy.cs 1 85.64%
Totals Coverage Status
Change from base Build 1814328769: -2.3%
Covered Lines: 735
Relevant Lines: 836
💛 - Coveralls

@cabauman
Copy link
Contributor

Looks good!

@saintedlama saintedlama merged commit 2aa68c7 into master Feb 11, 2022
@saintedlama saintedlama deleted the implement-pre-release-functionality branch February 11, 2022 12:48
@cabauman cabauman mentioned this pull request Feb 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabauman cabauman cabauman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saintedlama @cabauman @coveralls