Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect versions in xml namespaced projects #62

Merged
merged 1 commit into from
Feb 26, 2022
Merged

fix: detect versions in xml namespaced projects #62

merged 1 commit into from
Feb 26, 2022

Conversation

saintedlama
Copy link
Collaborator

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1902400454

  • 18 of 18 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 88.257%
Totals Coverage Status
Change from base Build 1867821994: 0.3%
Covered Lines: 749
Relevant Lines: 848
💛 - Coveralls

@saintedlama saintedlama mentioned this pull request Feb 26, 2022
Closed
@saintedlama saintedlama merged commit 7102a27 into master Feb 26, 2022
@saintedlama saintedlama deleted the fix-version-element-xml-namespace-lookup branch February 26, 2022 16:00
jmartens
jmartens reviewed Feb 26, 2022
View reviewed changes
Copy link

@jmartens jmartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the namespace it is still a .csproj file so I am not so sure on the chosen exception message mentioning it as being an xml file.

@saintedlama
Copy link
Collaborator Author

Could you provide an example xml file to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartens jmartens jmartens left review comments

@cabauman cabauman Awaiting requested review from cabauman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saintedlama @coveralls @jmartens