Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom INI parser #912

Open
borekb opened this issue Apr 12, 2016 · 0 comments
Open

Custom INI parser #912

borekb opened this issue Apr 12, 2016 · 0 comments
Assignees
@JanVoracek
Labels
feature New feature. See "improvement" for updates of existing functionality. scope: core Core VersionPress functionality like tracking actions, creating Git commits, etc. size: l Effort: 3-5 days
Milestone
5.0

Comments

@borekb
Copy link
Member

borekb commented Apr 12, 2016

parse_ini_string() is not entirely reliable and we already have quite a few workaround in our IniSerializer class. We're still encountering some new edge cases, e.g., #910, and it might be a good idea to create our own parser to avoid all the mess.

Note: Some alternative implementations were already discussed in #288 but there was not a good 3rd party library back then. We should try to find some exiting library again when we come to this issue.
@borekb borekb added feature New feature. See "improvement" for updates of existing functionality. scope: core Core VersionPress functionality like tracking actions, creating Git commits, etc. size: l Effort: 3-5 days labels Apr 12, 2016
@borekb borekb added this to the 4.0 milestone Apr 12, 2016
@borekb borekb mentioned this issue Apr 12, 2016
Open
Maxxa added a commit to Maxxa/versionpress that referenced this issue Sep 9, 2016
@Maxxa
[versionpress#912] Refactor IniSerialize method deserialize
7beb84c
@Maxxa Maxxa mentioned this issue Sep 9, 2016
Closed
1 task
@borekb borekb modified the milestones: 5.0, 4.0 May 8, 2017
@borekb borekb removed the in progress label May 8, 2017
@pavelevap pavelevap mentioned this issue Nov 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JanVoracek JanVoracek

Labels
feature New feature. See "improvement" for updates of existing functionality. scope: core Core VersionPress functionality like tracking actions, creating Git commits, etc. size: l Effort: 3-5 days
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
3 participants
@borekb @JanVoracek @Ishirak