-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future<HttpClientResponse> response() uses in HttpClientRequest/HttpClientResponse is undocumenteted #54
Comments
What do you think @vietj? |
you mean not documented in the regular docs ?
…On Mon, Dec 14, 2020 at 9:56 AM Jose Carranza ***@***.***> wrote:
What do you think @vietj <https://github.com/vietj>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCU4NHXQ3W3IJWSYZZTSUXHMVANCNFSM4UUWEY7Q>
.
|
I meant in the migration guide. |
alright, do you mind a contribution here ?
…On Mon, Dec 14, 2020 at 3:16 PM Jose Carranza ***@***.***> wrote:
I meant in the migration guide.
In the regular doc as far as I know neither.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCVO2FQBOIQIYG5P3GTSUYM47ANCNFSM4UUWEY7Q>
.
|
sure! |
We could add in the migration guide in the Http changes section and following the same styles of the other sections examples : In vertx 4, with the HttpClientRequest is used the Future response implementation and we return the future of the HttpClientResponse in the result method. The following example shows an example using HTTP client in {VertX} {v3x} releases:
The following example shows an example using HTTP client with the result method in {VertX} {v4x} releases:
what do you think @vietj ? |
can you do a PR it's easier for commenting. thanks |
sure! |
Hi @vietj, @jcarranzan, We can close this issue. It is resolved. |
Context
Now in vertx 4.0.0 when you do some HttpClientRequest and get the result if you want to do after some operation(compose, succeed,...) with the result before sending it, you have to add the response method that returns the Future
This change is shown in vertx examples in the core/http/proxy/client.java :
request.response().compose
vert-x3/vertx-examples@1ddfd8c#diff-330da0139766c23d1b970aa604bae5ed935b15ce6800348c696b0a5f6744f74b
But this change is not documented in the migration guide, maybe it would be nice to have some comment on Http changes or miscellaneous changes.
The text was updated successfully, but these errors were encountered: