[HttpClient-changes] handler the request-response in vertx4 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
reviewed
Dec 17, 2020
| @@ -201,3 +201,36 @@ response.end(ar -> { | |||
| } | |||
| }); | |||
| ---- | |||
| + | |||
|
|
|||
| On the other hand, we can handle the response with some operations if we want to. You can see the difference in the next examples. | |||
There was a problem hiding this comment.
@jcarranzan @vietj Can we rephrase this to:
You can also handle the response with operations. The following examples demonstrate handling responses with operations.
There was a problem hiding this comment.
ok I've updated it.
What do you think?
Thank you
| @@ -203,7 +203,8 @@ response.end(ar -> { | |||
| ---- | |||
| + | |||
|
|
|||
| On the other hand, we can handle the response with some operations if we want to. You can see the difference in the next examples. | |||
| On the other hand, you can also handle the response with operations like onSuccess, compose, bodyHandler, etc. | |||
| The following examples demonstrate handling responses with the operation onSuccess : | |||
|
|
|||
There was a problem hiding this comment.
You can also handle the response with methods such as, onSucces(), compose(), and bodyHandler().
The following examples demonstrate handling responses using the onSuccess() method.
There was a problem hiding this comment.
I would like to point here, that is not only those 3 methods, there are a few methods more.
asciidoc/modules/con_mg_migrating-applications-to-vertx-http-client.adoc
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Context
Now in vertx 4.0.0 when you do some HttpClientRequest and get the result if you want to do after some operation (compose, succeed,etc) with the result before sending it, you have to add the response method that returns the Future
This change is shown in vertx examples in the core/http/proxy/client.java :
request.response().compose
vert-x3/vertx-examples@1ddfd8c#diff-330da0139766c23d1b970aa604bae5ed935b15ce6800348c696b0a5f6744f74b