Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic module name #45

Merged
merged 1 commit into from
May 19, 2020
Merged

Add automatic module name #45

merged 1 commit into from
May 19, 2020

Conversation

afloarea
Copy link
Contributor

Signed-off-by: afloarea adrianfloarea07@yahoo.com

Motivation:

Add automatic module name as per vert-x3/issues#524

NOTE / FYI: on mvn clean package -DskipTests compilation failed with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile (default-compile) on project vertx-circuit-breaker: Compilation failure
[ERROR] /home/afloarea/Repositories/vertx/vertx-circuit-breaker/src/main/java/io/vertx/circuitbreaker/impl/CircuitBreakerMetrics.java:[29,82] cannot find symbol
[ERROR]   symbol:   method getNodeID()
[ERROR]   location: interface io.vertx.core.spi.cluster.ClusterManager

The line that caused the issue:

this.node = vertx.isClustered() ? ((VertxInternal) vertx).getClusterManager().getNodeID() : "local";

In order to test that the jar had the automatic module name I temporarily changed the line to this.node = "local"

Signed-off-by: afloarea <adrianfloarea07@yahoo.com>
@vietj vietj merged commit 2603cf2 into vert-x3:master May 19, 2020
@vietj vietj added this to the 4.0.0 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants