-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Infinispan 9.0.0.Beta2 #15
Conversation
3d198f4
to
316fdd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except the version (see comments)
pom.xml
Outdated
@@ -34,7 +34,7 @@ | |||
<properties> | |||
<stack.version>3.4.0-SNAPSHOT</stack.version> | |||
<asciidoc.dir>${project.basedir}/src/main/asciidoc</asciidoc.dir> | |||
<infinispan.version>8.2.5.Final</infinispan.version> | |||
<infinispan.version>9.0.0.Beta1</infinispan.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there's a 9.0.0.Beta2
already, can we upgrade to this one instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure there were some issues with resolving Beta2 in maven central so I was just playing it safe [1]. I will put in Beta2 though.
[1] http://lists.jboss.org/pipermail/infinispan-dev/2017-January/017149.html
e0f3960
to
e6361a3
Compare
is invoked in context thread
e6361a3
to
4a647d8
Compare
Alright it should be all updated to Beta2. Updated schema and removed default cache definition. Also added a commit to ensure when used outside of a vert.x thread that the handler is always invoked on the vert.x context thread. |
Thanks @wburns and congrats for your first Vert.x PR ;-) |
Upgraded to latest Infinispan 9.0.0.Beta2. This way when Final comes out there shouldn't be any required changes. Note this also upgrades JGroups to the latest 4.0.0.Beta3.