Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Infinispan 9.0.0.Beta2 #15

Merged
merged 2 commits into from
Feb 7, 2017

Conversation

wburns
Copy link
Contributor

@wburns wburns commented Feb 7, 2017

Upgraded to latest Infinispan 9.0.0.Beta2. This way when Final comes out there shouldn't be any required changes. Note this also upgrades JGroups to the latest 4.0.0.Beta3.

Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except the version (see comments)

pom.xml Outdated
@@ -34,7 +34,7 @@
<properties>
<stack.version>3.4.0-SNAPSHOT</stack.version>
<asciidoc.dir>${project.basedir}/src/main/asciidoc</asciidoc.dir>
<infinispan.version>8.2.5.Final</infinispan.version>
<infinispan.version>9.0.0.Beta1</infinispan.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there's a 9.0.0.Beta2 already, can we upgrade to this one instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure there were some issues with resolving Beta2 in maven central so I was just playing it safe [1]. I will put in Beta2 though.

[1] http://lists.jboss.org/pipermail/infinispan-dev/2017-January/017149.html

@wburns
Copy link
Contributor Author

wburns commented Feb 7, 2017

Alright it should be all updated to Beta2. Updated schema and removed default cache definition. Also added a commit to ensure when used outside of a vert.x thread that the handler is always invoked on the vert.x context thread.

@wburns wburns changed the title Upgrade to Infinispan 9.0.0.Beta1 Upgrade to Infinispan 9.0.0.Beta2 Feb 7, 2017
@tsegismont
Copy link
Contributor

Thanks @wburns and congrats for your first Vert.x PR ;-)

@tsegismont tsegismont merged commit f92b472 into vert-x3:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants