Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kotlin 1.3 #88

Closed
vietj opened this issue Oct 30, 2018 · 10 comments · Fixed by #90
Closed

Use Kotlin 1.3 #88

vietj opened this issue Oct 30, 2018 · 10 comments · Fixed by #90
Milestone

Comments

@vietj
Copy link
Contributor

vietj commented Oct 30, 2018

Kotlin 1.3 was recently released, it should be used in Vert.x 3.6 release.

@vietj vietj added this to the 3.6.0 milestone Oct 30, 2018
@vietj
Copy link
Contributor Author

vietj commented Oct 30, 2018

@gmariotti interested to tackle this ?

@gmariotti
Copy link
Contributor

that was my goal after reopening the previous MR 😂. More than happy to help there

@dualscyther
Copy link
Contributor

dualscyther commented Oct 30, 2018

Just putting this here for future reference:

https://github.com/Kotlin/kotlinx.coroutines/blob/master/COMPATIBILITY.md

We will have to think carefully about whether upgrading to stable coroutines will break backwards compatibility (I haven't really looked too hard at this).

@dualscyther
Copy link
Contributor

dualscyther commented Nov 3, 2018

@gmariotti are you working on this? I'd also be keen to help out. It might be a good time to make API improvements too since we're likely to break the API anyway given our upgrade to new coroutines with the structured concurrency model.

@gmariotti
Copy link
Contributor

@dualscyther not yet. I'd like to have #89 in first so that all the deprecated coroutines code is removed and then starting the migration. I quickly tried on my machine and the coroutines migration is quite simple the moment all the deprecated code is removed.

@gmariotti
Copy link
Contributor

gmariotti commented Nov 7, 2018

@vietj you should announce the completed migration to Kotlin 1.3 and coroutines 1.0 on the Kotlin Slack workspace

@vietj
Copy link
Contributor Author

vietj commented Nov 7, 2018

yes, are you present on that space ?

@gmariotti
Copy link
Contributor

Yes, should I post something there? I can also share a tweet from you in some of the main channels

@vietj
Copy link
Contributor Author

vietj commented Nov 7, 2018

I've posted there

@vietj
Copy link
Contributor Author

vietj commented Nov 7, 2018

do the most noise you can :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants