New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router DSL #151
Router DSL #151
Conversation
@vietj As far as testing the DSL how would you like that to be done? I would normally use mockk to perform the testing but I'm not sure if its okay to add a new dependency to the project. |
Directory vertx-lang-kotlin/vertx-lang-kotlin/pom.xml Lines 808 to 817 in c208e3a
So it is recommended to move the code to the |
vertx-lang-kotlin/src/main/kotlin/io/vertx/kotlin/ext/web/api/contract/RouterFactoryOptions.kt
Outdated
Show resolved
Hide resolved
vertx-lang-kotlin/src/main/kotlin/io/vertx/kotlin/ext/web/api/contract/RouterFactoryOptions.kt
Outdated
Show resolved
Hide resolved
|
||
|
||
fun main() { | ||
val vertx = Vertx.vertx() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have example with no coroutine as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an example with no coroutines! Also added an example with the route builder because that was one piece of the dsl that I wanted feedback on.
Also another thing I was thinking about was the DslServer and DslRouter are also a coroutine scope is that going to be a problem?
Maybe I'm not understanding but all the source files for this project are in I've included what I'm seeing in intellij below: |
@Tim-Britton have you check the |
Superseded by #253 |
Hello All,
This pull request includes the Router DSL that I am working on. See #91
Any feedback is welcome!
Tim