Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable regression in codegen TCK #78

Closed
vietj opened this issue Nov 8, 2018 · 3 comments
Closed

Nullable regression in codegen TCK #78

vietj opened this issue Nov 8, 2018 · 3 comments
Assignees
@codepitbull
Milestone
4.0.0

Comments

@vietj
Copy link
Contributor

vietj commented Nov 8, 2018 

Running io.vertx.lang.scala.tck.ApiTest
Tests run: 59, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.121 sec <<< FAILURE! - in io.vertx.lang.scala.tck.ApiTest
testNullJsonParams should work(io.vertx.lang.scala.tck.ApiTest)  Time elapsed: 0.01 sec  <<< ERROR!
java.lang.NullPointerException: null
	at io.vertx.scala.codegen.testmodel.TestInterface.methodWithNullJsonParams(TestInterface.scala:411)
	at io.vertx.lang.scala.tck.ApiTest.$anonfun$new$158(ApiTest.scala:650)

testNullJsonHandlerAsyncResultParams should work(io.vertx.lang.scala.tck.ApiTest)  Time elapsed: 0.016 sec  <<< ERROR!
org.scalatest.exceptions.TestFailedException: null did not equal None
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:528)
	at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:527)
	at org.scalatest.FlatSpec.newAssertionFailedException(FlatSpec.scala:1685)
	at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:501)
	at io.vertx.lang.scala.tck.ApiTest.$anonfun$new$174(ApiTest.scala:698)
@vietj
Copy link
Contributor Author

vietj commented Nov 8, 2018

likely related to this change: eclipse-vertx/vertx-codegen@a6ed3e1

vietj added a commit that referenced this issue Nov 8, 2018
@vietj
Comment tests that fail unexpectedly : see #78
a13284c
@vietj vietj added this to the 3.6.0 milestone Nov 8, 2018
@codepitbull
Copy link
Contributor

Will take care of it.

@vietj vietj modified the milestones: 3.6.0, 4.0.0 Nov 29, 2018
@codepitbull
Copy link
Contributor

All clear in 3.x branches.
4.0 Branch is currently a preview and not affected by this.

willisjtc added a commit to willisjtc/vertx-lang-scala that referenced this issue Jun 19, 2021
@willisjtc
Comment tests that fail unexpectedly : see vert-x3#78
e895520
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codepitbull codepitbull

Labels
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@vietj @codepitbull