Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue48 hostnamenotasync #50

Merged
merged 5 commits into from Jan 9, 2016
Merged

Issue48 hostnamenotasync #50

merged 5 commits into from Jan 9, 2016

Commits on Dec 20, 2015

  1. moved getHostname into executeBlocking block before calling sendMail,… 

    … hostname is passed

between the different classes and is cached in a field in MailClientImpl.
This is still wip, I am not happy with the constructors passing hostname, there should be an easier
way to this.
This has currently no test, I have starting writing a test with EasyMock/PowerMock, but that is not working

Signed-off-by: alexlehm <alexlehm@gmail.com>
    @alexlehm
    alexlehm committed Dec 20, 2015
    Copy the full SHA
    d9730ac View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2016

  1. remove log line 

    (for now decided to go without a test, the powermock stuff is too complicated, otherwise it would be necessary to rewrite the static class to facilitate testing)

Signed-off-by: alexlehm <alexlehm@gmail.com>
    @alexlehm
    alexlehm committed Jan 5, 2016
    Copy the full SHA
    0a0e692 View commit details
    Browse the repository at this point in the history

  2. whitespace 

    Signed-off-by: alexlehm <alexlehm@gmail.com>
    @alexlehm
    alexlehm committed Jan 5, 2016
    Copy the full SHA
    55e7c20 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2016

  1. removed unnecessary log statement 

    set hostname in event thread, not in worker
do not pass vertx to SMTPStarter since its not used

Signed-off-by: alexlehm <alexlehm@gmail.com>
    @alexlehm
    alexlehm committed Jan 8, 2016
    2
    Copy the full SHA
    3b2ff56 View commit details
    Browse the repository at this point in the history

  2. access hostname only from event loop thread 

    Signed-off-by: alexlehm <alexlehm@gmail.com>
    @alexlehm
    alexlehm committed Jan 8, 2016
    Copy the full SHA
    19fe4d1 View commit details
    Browse the repository at this point in the history