Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findBatch doesn't work with RX API #110

Closed
diabolicallabs opened this issue Jul 6, 2017 · 0 comments
Closed

findBatch doesn't work with RX API #110

diabolicallabs opened this issue Jul 6, 2017 · 0 comments
Assignees
Milestone

Comments

@diabolicallabs
Copy link
Contributor

The findBatch operation calls the result handler multiple times with each document in a batch. When finished, it sends a null object. This doesn't work with the RX API as it generates code that returns a Single since the result handler only mentions one document. So all we ever get is the first document instead of an observable stream of documents.

Perhaps a batch read stream should be created instead. Actually a batch write stream would be nice too. Such an implementation would diverge from the current service proxy api but would be very useful in dealing with large datasets with RX and in general.

@karianna karianna added this to the 3.x.x milestone Jul 6, 2017
@tsegismont tsegismont self-assigned this Dec 7, 2017
tsegismont added a commit to tsegismont/vertx-mongo-client that referenced this issue Dec 7, 2017
Update xxxBatch methods to return a ReadStream

For MongoService, these methods cannot be supported
(no support for ReadStream in proxy gen)
tsegismont added a commit to tsegismont/vertx-mongo-client that referenced this issue Dec 8, 2017
@vietj vietj removed the to review label Dec 20, 2017
@karianna karianna modified the milestones: 3.x.x, 3.5.1 Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants