Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop client consumer issue #71

Closed
spydevil opened this issue Jul 4, 2018 · 5 comments
Closed

Stop client consumer issue #71

spydevil opened this issue Jul 4, 2018 · 5 comments

Comments

@spydevil
Copy link

spydevil commented Jul 4, 2018

Hi,
I'm using vertx api 3.5.2.

How I can stop or unregister consumer, registered with client.basicConsume. I think this api version(3.5.2) doesn't support yet, it will be support with new version(3.6.0) https://vertx.io/blog/eclipse-vert-x-rabbitmq-client-gets-a-new-consumer-api/

My original question:
https://stackoverflow.com/questions/51161691/vert-x-rabbitmq-endless-loop-issue
@vietj
Copy link
Contributor

vietj commented Jul 4, 2018

@Sammers21 ping

@Sammers21
Copy link
Contributor

Sammers21 commented Jul 4, 2018 •
edited
Loading

@spydevil, you are right, in 3.5.2 you are not allowed to stop consumption without stopping the client. In 3.6.0 you can call RabbitMQConsumer#cancel.

@Sammers21
Copy link
Contributor

@vietj, do you think we should have API for this even if basicConsume going to be deprecated in 3.6.0?

@vietj
Copy link
Contributor

vietj commented Jul 4, 2018

can you provide a fix soon for 3.6.0 that we can backport to 3.5.2 ?

Sammers21 added a commit to Sammers21/vertx-rabbitmq-client that referenced this issue Jul 4, 2018
@Sammers21
add basicCancel method -fixes vert-x3#71
889565d
@Sammers21 Sammers21 mentioned this issue Jul 4, 2018
Merged
Sammers21 added a commit to Sammers21/vertx-rabbitmq-client that referenced this issue Jul 4, 2018
@Sammers21
add basicCancel method - fixes vert-x3#71
f22c55b
@Sammers21
Copy link
Contributor

@vietj , sure, here is the PR: #72.

@vietj vietj closed this as completed in 3a44320 Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vietj @Sammers21 @spydevil